[Feat] 프로젝트 관련 API 구현 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iam454
reviewed
Nov 12, 2024
| @@ -17,7 +19,7 @@ export class TypeormConfig implements TypeOrmOptionsFactory { | |||
| username: this.configService.get<string>('DATABASE_USER'), | |||
| password: this.configService.get<string>('DATABASE_PASSWORD'), | |||
| database: this.configService.get<string>('DATABASE_NAME'), | |||
| entities: [Task, Section, Account], | |||
| entities: [Task, Section, Account, Project, Contributor], | |||
There was a problem hiding this comment.
팀원이라고 보시면 됩니다. 초대 관련 여러가지 정보를 담고 있어요
yangchef1
reviewed
Nov 12, 2024
Comment on lines
+142
to
+148
| if (!contributor) { | ||
| throw new NotFoundException('Does not found invitation'); | ||
| } else if (contributor.userId !== userId) { | ||
| throw new ForbiddenException('Permission denied'); | ||
| } else if (contributor.status !== ContributorStatus.PENDING) { | ||
| throw new BadRequestException('Already update invitation'); | ||
| } |
There was a problem hiding this comment.
🟢
service 코드에서 else if와 Early Return 방식이 모두 보이는데, 통일성있게 작성하는게 좋아보여요 !
개인적으로 else if를 여러번 사용하는 것보단 Early Return 방식이 가독성이 좋다고 생각합니다 !
There was a problem hiding this comment.
엇 그러네요 이 부분은 수정해두겠습니다
yangchef1
reviewed
Nov 12, 2024
Comment on lines
+53
to
+58
| const userContributor = await this.contributorRepository.findOneBy({ userId, projectId }); | ||
| if (!userContributor) { | ||
| throw new NotFoundException('Does not found user contributor or project'); | ||
| } else if (userContributor.status !== ContributorStatus.ACCEPTED) { | ||
| throw new ForbiddenException('Permission denied'); | ||
| } |
There was a problem hiding this comment.
🟢
이 코드는 유사한 형태가 3번 정도 반복되는 것 같네요 !
별도 함수로 분리하셔도 좋을 것 같아요.
yangchef1
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
#54 #56 #64
작업 내용
고민과 학습내용
어제 pr에서의 피드백 적용 및 새로운 기능을 추가했습니다.