-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] 여정 조회 개선 #350
Merged
Merged
[iOS] 여정 조회 개선 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSMusicPlayerView 컴포넌트 분리
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 배경
🔧 작업 내역
📝 리뷰 노트
push ➡️ present
이전에
push
를 사용해UIPanGestureRecognizer
를 사용해 여정 조회를 종료시킬 때화면이 옆으로 이동한 빈 공간이 검은 색인 문제를 해결하고자
화면 전환 방식을
push
에서present
로 변경하고 presentationStyle을overFullscreen
으로 설정했습니다.그 과정에서 presentationStyle에 왼쪽 모서리 ➡️ 오른쪽으로 전환하는 스타일이 없어
위 ➡️ 아래로 내려야 화면이 종료되도록 수정해주었습니다.
MSMusicPlayerView &
.stopped
상태 시 화면 종료별도의 컴포넌트로서
MSUIKit
에 분리했습니다.추가적으로
Bool
프로퍼티isPlaying
으로 재생 여부를 관리하던 방식에서PlaybackStatus
열거형을 사용하는 방식으로 개선해주었습니다.\.stopped
상태에서는 여정 조회 화면이dismiss
되도록 수정해주었는데,이를 위해
.stopped
상태와.paused
상태의 구분이 필요했기 때문입니다.📸 스크린샷