Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Fix: return value가 정의되지 않은 값이라면 에러 처리 #238

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

h9661
Copy link
Collaborator

@h9661 h9661 commented Dec 6, 2023

No description provided.

@h9661 h9661 self-assigned this Dec 6, 2023
Copy link
Collaborator

@kushinada2077 kushinada2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

error += "Error: return value is undefined";
} else {
status =
childMessages[0].toString().trim() == testcase.output
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소하지만 여기두 === 으로 쓰는 게 좋을 듯!!

childMessages[0].toString().trim() == testcase.output ? "pass" : "fail";
if (!childMessages[0]) {
status = "fail";
error += "Error: return value is undefined";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엣지케이스 처리 너무 좋고~~

@kushinada2077 kushinada2077 merged commit d758de1 into main Dec 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants