Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize variables in ob_tran projection #1275

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Initialize variables in ob_tran projection #1275

wants to merge 1 commit into from

Conversation

vissarion
Copy link
Member

This PR intents to prevent a maybe uninitialized warning that appear with recent versions of gcc (11 and 12).

barendgehrels
barendgehrels approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@barendgehrels barendgehrels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work indeed.
But why don't we initialize it where the variable is declared (the C++11 way)?

@vissarion
Copy link
Member Author

This should work indeed. But why don't we initialize it where the variable is declared (the C++11 way)?

You are right, I was following the old style of the file, now they are initialized where they declared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barendgehrels barendgehrels barendgehrels approved these changes

@awulkiew awulkiew Awaiting requested review from awulkiew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vissarion @barendgehrels