Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix covered_by incorrect results #1283

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

vissarion
Copy link
Member

Fix covered_by incorrect results for polygons with multiple defined points as a pole.

Resolves #1279 (the special case arise as part of issue #1161)

calc_t s1 = get<0>(seg1);
calc_t s2 = get<0>(seg2);

// In case of a segment that contains a pole endpoint we need an arbitrary but consistant
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> consistent

Copy link
Collaborator

@barendgehrels barendgehrels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vissarion vissarion force-pushed the fix/covered_by_multiple_poles branch 2 times, most recently from 1f03912 to f90952c Compare May 30, 2024 09:07
@vissarion vissarion force-pushed the fix/covered_by_multiple_poles branch from f90952c to aa840ec Compare May 30, 2024 09:08
@vissarion vissarion merged commit 7785bd6 into boostorg:develop Jul 24, 2024
23 checks passed
@vissarion vissarion deleted the fix/covered_by_multiple_poles branch July 24, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants