Fix/use biconnected components #1357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
added
the
experimental
barendgehrels
force-pushed
the
fix/use-biconnected-components
branch
from
c4fc5e3 to
61b002b
Compare
|
As I had in mind, we can use this method for traversal too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR using Boost.Graph biconnected components to detect isolation.
From Boost.Graph:
The numbers are the biconnected components. The letters are the articulation points, but they are not necessary in the end (though for graph display it might be useful).
The big advantages:
traversal_switch_detector.hppIt fixes the issues also mentioned in PR 1350 and 1356
NOTE: it's only commit 61b002b
The basic functionality is shown in the next (manually edited) picture (the basis comes from overlay.cpp -> geojson -> qgis)
The corresponding graph-viz-graph is here. It uses the same turn indexes and component ids. Clusters are denoted as negative indexes. Extra nodes (necessary for if a turn is traveling to itself) have high numbers (>10000)