Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formulas] Fix warning (variable hiding member) in sjoberg_intersection #1365

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[formulas] Fix warning (variable hiding member) in sjoberg_intersection #1365

merged 1 commit into from
Jan 13, 2025

Conversation

awulkiew
Copy link
Member

@awulkiew awulkiew commented Jan 11, 2025 •
edited
Loading

This variable is already calculated in the constructor

vissarion
vissarion approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix Adam. I agree with merging.

@awulkiew awulkiew merged commit fe817e6 into boostorg:develop Jan 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinko92 tinko92 tinko92 approved these changes

@vissarion vissarion vissarion approved these changes

@barendgehrels barendgehrels barendgehrels approved these changes

Assignees
No one assigned
Labels
warning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awulkiew @barendgehrels @vissarion @tinko92