Skip to content

Commit

Permalink
Bumps version number to 5.5.3
Browse files Browse the repository at this point in the history
  • Loading branch information
tiesont committed Apr 28, 2022
1 parent 89715ba commit b6e0fc2
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 20 deletions.
10 changes: 4 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ Please see the [CONTRIBUTING](https://github.com/makeusabrew/bootbox/blob/master

Tests are run using [Karma](http://karma-runner.github.io/0.8/index.html) using the Mocha test adapter.
To run the tests yourself, simply run ```npm install``` within the project followed by ```npm test```.
Please note that this will require [PhantomJS](http://phantomjs.org/) being installed and in your path - if
it is not, you may run the tests and capture browsers manually by running ```karma start``` from the root
of the project.

The project is also hosted on [Travis CI](https://travis-ci.org/makeusabrew/bootbox) - when submitting

This comment has been minimized.

Copy link
@jstark518

jstark518 Apr 28, 2022

Contributor

@tiesont Looks like there isn't any recent builds on there

This comment has been minimized.

Copy link
@tiesont

tiesont Apr 28, 2022

Author Member

@jstark518 I assume you mean npm? Correct, I haven't updated npm yet. If you're referring to Travis CI, it looks like the .org version was shutdown since I last looked, and I don't have a sense of urgency compelling me to setup a new CI on the .com domain.

This comment has been minimized.

Copy link
@tiesont

tiesont Apr 28, 2022

Author Member

Also, this isn't a Bootstrap 5-based release, just trying to clean some PRs up and push a few fixes.

This comment has been minimized.

Copy link
@jstark518

This comment has been minimized.

Copy link
@jstark518

jstark518 Apr 28, 2022

Contributor

If you would like I could write a github actions script to run the tests

This comment has been minimized.

Copy link
@tiesont

tiesont Apr 28, 2022

Author Member

Yeah, the .org version was apparently shut down. I can't do anything about that. A new CI would need to be setup on travis-ci.com, which isn't going to happen in the near future.

This comment has been minimized.

Copy link
@tiesont

tiesont Apr 28, 2022

Author Member

If you would like I could write a github actions script to run the tests

Sure, if that's easy enough and doesn't require admin access on this repo - @tarlepp and I are only collaborators, so there's a limit to what I can change.

This comment has been minimized.

Copy link
@jstark518

jstark518 Apr 28, 2022

Contributor

If you would like I could write a github actions script to run the tests

Sure, if that's easy enough and doesn't require admin access on this repo - @tarlepp and I are only collaborators, so there's a limit to what I can change.

I'm not sure but I will research it a bit and get back to you in the next couple days

This comment has been minimized.

Copy link
@tiesont

tiesont Apr 28, 2022

Author Member

No rush.

pull requests **please** ensure your tests pass as failing requests will be rejected. See the
Expand All @@ -35,17 +32,18 @@ Bootbox **3.3.0** is the *last* release to support Bootstrap 2.2.x.

Much more dependency information can be found [on the Bootbox website](http://bootboxjs.com/getting-started.html#bootbox-dependencies).

## 5.5.2 (Latest Release)
## 5.5.3 (Latest Release)

- Adds Vietnamese locale
- Adds `relatedTarget` option. Allows the caller to determine which element, if any, triggered the modal
- Various bugfixes and package updates

For a full list of releases and changes please see [the changelog](https://github.com/makeusabrew/bootbox/blob/master/CHANGELOG.md).

## License

(The MIT License)

Copyright (C) 2011-2020 by Nick Payne <nick@kurai.co.uk>
Copyright (C) 2011-2022 by Nick Payne <nick@kurai.co.uk>

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
8 changes: 5 additions & 3 deletions bootbox.all.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@

var exports = {};

var VERSION = '5.5.2';
var VERSION = '5.5.3';
exports.VERSION = VERSION;

var locales = {
Expand Down Expand Up @@ -356,7 +356,9 @@
// Automatically scroll modal content when height exceeds viewport height
scrollable: false,
// whether or not to destroy the modal on hide
reusable: false
reusable: false,
// the element that triggered the dialog opening
relatedTarget: null
};


Expand Down Expand Up @@ -705,7 +707,7 @@
});

if (options.show) {
dialog.modal('show');
dialog.modal('show', options.relatedTarget);
}

return dialog;
Expand Down
4 changes: 2 additions & 2 deletions bootbox.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*! @preserve
* bootbox.js
* version: 5.5.2
* version: 5.5.3
* author: Nick Payne <nick@kurai.co.uk>
* license: MIT
* http://bootboxjs.com/
Expand Down Expand Up @@ -65,7 +65,7 @@

var exports = {};

var VERSION = '5.5.2';
var VERSION = '5.5.3';
exports.VERSION = VERSION;

var locales = {
Expand Down
2 changes: 1 addition & 1 deletion bootbox.locales.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*! @preserve
* bootbox.locales.js
* version: 5.5.2
* version: 5.5.3
* author: Nick Payne <nick@kurai.co.uk>
* license: MIT
* http://bootboxjs.com/
Expand Down
4 changes: 2 additions & 2 deletions dist/bootbox.all.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/bootbox.locales.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/bootbox.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion header.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* bootbox.js 5.5.2
* bootbox.js 5.5.3
*
* http://bootboxjs.com/license.txt
*/
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"name": "bootbox",
"version": "5.5.2",
"version": "5.5.3",
"description": "Wrappers for JavaScript alert(), confirm(), prompt(), and other flexible dialogs using the Bootstrap framework",
"directories": {
"test": "tests"
},
"scripts": {
"test": "./node_modules/.bin/karma start"
"test": "karma start"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit b6e0fc2

Please sign in to comment.