feat: Showing a warning when AuthEmail is configured as it is depreca…

…ted now
boris1993 · Sep 14, 2022 · 64b5ce3 · 64b5ce3
1 parent cbf67ec
commit 64b5ce3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/internal/common/errormsg.go b/internal/common/errormsg.go
@@ -1,4 +1,4 @@
-// Package constants contains all constants needed in this programme
+// Package common contains all constants needed in this programme
 package common
 
 const MsgHeaderDNSRecordUpdateSuccessful = "Successfully updated the DNS record"
@@ -31,3 +31,5 @@ const ErrCloudFlareAPIAddressEmpty = "CloudFlare API endpoint address cannot be
 const ErrAliyunAPIAddressEmpty = "Aliyun API endpoint address cannot be empty"
 const ErrCloudFlareRecordConfigIncomplete = "Incomplete CloudFlare configuration found"
 const ErrAliDNSRecordConfigIncomplete = "Incomplete Aliyun DNS configuration found"
+
+const WarnAuthEmailDeprecated = "AuthEmail is deprecated. Please use dedicated API token if you are still using Global API Key."
diff --git a/internal/helper/cloudflare/cloudflare_dns_helper.go b/internal/helper/cloudflare/cloudflare_dns_helper.go
@@ -7,7 +7,7 @@ import (
 	"github.com/boris1993/dnsupdater/internal/common"
 	"github.com/boris1993/dnsupdater/internal/conf"
 	log "github.com/sirupsen/logrus"
-	"io/ioutil"
+	"io"
 	"net/http"
 )
 
@@ -135,7 +135,7 @@ func getCFDnsRecordIpAddress(cloudFlareRecord conf.CloudFlare) (string, string,
 		return "", "", err
 	}
 
-	body, err := ioutil.ReadAll(resp.Body)
+	body, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return "", "", err
 	}
@@ -234,7 +234,7 @@ func updateCFDNSRecord(id string, address string, cloudFlareRecord conf.CloudFla
 		}
 	}()
 
-	body, err := ioutil.ReadAll(resp.Body)
+	body, err := io.ReadAll(resp.Body)
 
 	if err != nil {
 		return false, err
@@ -259,5 +259,7 @@ func composeRequestHeader(req *http.Request, cloudFlareRecord conf.CloudFlare) {
 
 	if cloudFlareRecord.AuthEmail != "" {
 		req.Header.Add("X-Auth-Email", cloudFlareRecord.AuthEmail)
+
+		log.Warn(common.WarnAuthEmailDeprecated)
 	}
 }