Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue
Resolves #873
Background
In debug mode, SEBAK produces huge log messages including HTTP requests and responses log. Under docker, we can use
max-size
setting in log driver, but a node can keep the entire log messages, it's the matter of choice.Solution
There are 2 logs, node log, and HTTP log. Each log will have rotate options,
--log-rotate-max-size
,--http-log-rotate-max-size
: if log file is over, rotate log--log-rotate-max-age
,--http-log-rotate-max-age
: if log file is over days, rotate log--log-rotate-max-count
,--http-log-rotate-max-count
: if the number of rotated logs over, remove olds--log-rotate-uncompress
,--http-log-rotate-uncompress
: compress or not