Skip to content

Commit

Permalink
Removing wrong comments and adding todo notes
Browse files Browse the repository at this point in the history
  • Loading branch information
anajuliabit committed Jul 7, 2023
1 parent f608e92 commit c27cfc0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions test/protocol/ProtocolInitializationHandlerTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,7 @@ describe("ProtocolInitializationHandler", async function () {
);
const [beacon] = beacons;

// @TODO move this to 00_config.js:getFacets
const facetsToDeploy = await getV2_2_0DeployConfig(); // To deploy 2.2.1, we can use 2.2.0 config
facetsToDeploy.ConfigHandlerFacet.init[0] = {
...facetsToDeploy.ConfigHandlerFacet.init[0],
Expand Down Expand Up @@ -816,7 +817,6 @@ describe("ProtocolInitializationHandler", async function () {
});

it("Min resolution period is zero", async function () {
// set invalid minResolutionPeriod
version = "2.3.0";
minResolutionPeriod = "0";
initializationData = abiCoder.encode(["uint256", "uint256[]", "address[]"], [minResolutionPeriod, [], []]);
Expand All @@ -838,7 +838,6 @@ describe("ProtocolInitializationHandler", async function () {
});

it("sellerIds and sellerCreators length mismatch", async function () {
// set invalid minResolutionPeriod
version = "2.3.0";
initializationData = abiCoder.encode(["uint256", "uint256[]", "address[]"], [minResolutionPeriod, [1], []]);

Expand All @@ -859,7 +858,6 @@ describe("ProtocolInitializationHandler", async function () {
});

it("invalid seller id ", async function () {
// set invalid minResolutionPeriod
initializationData = abiCoder.encode(
["uint256", "uint256[]", "address[]"],
[minResolutionPeriod, [66], [rando.address]]
Expand Down

0 comments on commit c27cfc0

Please sign in to comment.