-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ether.js v6 migration #688
Conversation
Bumps [@nomicfoundation/hardhat-toolbox](https://github.com/nomicfoundation/hardhat) from 2.0.2 to 3.0.0. - [Release notes](https://github.com/nomicfoundation/hardhat/releases) - [Commits](https://github.com/nomicfoundation/hardhat/compare/@nomicfoundation/hardhat-toolbox@2.0.2...@nomicfoundation/hardhat-toolbox@3.0.0) --- updated-dependencies: - dependency-name: "@nomicfoundation/hardhat-toolbox" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
ab23430
to
52781ee
Compare
d779450
to
7d1d6d3
Compare
cef4145
to
3947575
Compare
2dadb38
to
86d4f38
Compare
ab589e1
to
336c3f9
Compare
@zajck good catches, I applied all! |
0cb7b84
to
11dba7b
Compare
9048048
to
e8a4973
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And a few things that I couldn't comment directly:
- There's another case of
toHexString
boson-protocol-contracts/test/util/utils.js
Line 271 in e8a4973
const pBuffer = Buffer.from(slot.toHexString().slice(2), "hex"); - in
test/util/upgrade.js
, we haveBigInt.toNumber()
in some places and it should be changed toNumber(BigInt)
. This happens on lines 470, 523, 539, 540, 620, 1236*, 1365*, 1392*, 1679, 1733. In those marked with*
you can probably even get rid of all casting and just assign store to variable whatevergetStorageAt
returns
I guess these are my last requests. If we miss something in the upgrade test files, I'll find it anyway when I merge this into upgrade tests.
34df143
to
781ccaa
Compare
abe78bd
to
21d912b
Compare
21d912b
to
353cb4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
Remediate #678