Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve time conflict in redeemVoucher and expireVoucher #695

Merged
merged 7 commits into from
Jul 6, 2023
Merged

Resolve time conflict in redeemVoucher and expireVoucher #695

merged 7 commits into from
Jul 6, 2023

Conversation

zajck
Copy link
Member

@zajck zajck commented Jun 21, 2023

Fix #692

@zajck zajck self-assigned this Jun 21, 2023
@zajck zajck added bug Something isn't working v2.3.0 labels Jun 21, 2023
@coveralls
Copy link

coveralls commented Jun 21, 2023 •
edited
Loading

Coverage Status

coverage: 99.704%. remained the same when pulling 1d00a7c on expire-redeem-time-conflict into db2c489 on main.

mischat
mischat approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anajuliabit
anajuliabit reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@anajuliabit anajuliabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anajuliabit anajuliabit merged commit f14d952 into main Jul 6, 2023
11 checks passed
@anajuliabit anajuliabit deleted the expire-redeem-time-conflict branch July 6, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischat mischat mischat approved these changes

@anajuliabit anajuliabit anajuliabit approved these changes

Assignees

@zajck zajck

Labels
bug Something isn't working v2.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expireVoucher and redeemVoucher have a time conflict
4 participants
@zajck @coveralls @mischat @anajuliabit