More flexible getAvailableFunds #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajck
force-pushed
the
dos-getAvailableFunds
branch
from
52eb23f
to
c26cd09
Compare
zajck
force-pushed
the
dos-getAvailableFunds
branch
from
c26cd09
to
aa6abe9
Compare
|
Changes unknown when pulling d1b50d3 on dos-getAvailableFunds into ** on main**. |
|
and more merge conflicts here @zajck |
|
fwiw, I would have totally just removed the "name" field, and make that the client's problem, but i like the solution here nonetheless... |
anajuliabit
suggested changes
Jul 7, 2023
| /** | ||
| * @notice Returns list of addresses for which the entity has funds available. | ||
| * | ||
| * @param _entityId - id of entity for which availability of funds should be checked |
There was a problem hiding this comment.
add _limit and _offset parameters here
| /** | ||
| * @notice Returns list of addresses for which the entity has funds available. | ||
| * | ||
| * @param _entityId - id of entity for which availability of funds should be checked |
There was a problem hiding this comment.
add _limit and _offset parameters here
| @@ -189,6 +240,8 @@ contract FundsHandlerFacet is IBosonFundsHandler, ProtocolBase { | |||
| availableFunds[i].tokenName = tokenName; | |||
| availableFunds[i].availableAmount = entityFunds[tokenAddress]; | |||
| } | |||
|
|
|||
| return availableFunds; | |||
There was a problem hiding this comment.
no need for this return exist
anajuliabit
approved these changes
Jul 7, 2023
mischat
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546
And also alleviates the consequences of #322 and #679