Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remediate [BVR-06M] Insufficient Protection of Contract Assets #753

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Remediate [BVR-06M] Insufficient Protection of Contract Assets #753

merged 6 commits into from
Aug 22, 2023

Conversation

zajck
Copy link
Member

@zajck zajck commented Aug 4, 2023

Fix #743

@coveralls
Copy link

coveralls commented Aug 4, 2023 •
edited
Loading

Coverage Status

coverage: 99.652%. remained the same when pulling 1c553b8 on audit_v2_3_0_bvr_06_m into d88ad53 on main.

@zajck zajck self-assigned this Aug 4, 2023
@zajck zajck added bug Something isn't working v2.3.0 labels Aug 4, 2023
zajck and others added 2 commits August 17, 2023 17:13
@zajck @albertfolch-redeemeum
Apply suggestions from code review
466c907 
Co-authored-by: albertfolch-redeemeum <102516373+albertfolch-redeemeum@users.noreply.github.com>
@levalleux-ludo
Merge branch 'main' into audit_v2_3_0_bvr_06_m
6fd6bbc
levalleux-ludo
levalleux-ludo requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@levalleux-ludo levalleux-ludo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zajck 2 small suggestions

contracts/protocol/clients/voucher/BosonVoucher.sol Outdated Show resolved Hide resolved
contracts/protocol/clients/voucher/BosonVoucher.sol Outdated Show resolved Hide resolved
@zajck @levalleux-ludo
Apply suggestions from code review
1c553b8 
Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
levalleux-ludo
levalleux-ludo approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@levalleux-ludo levalleux-ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levalleux-ludo levalleux-ludo merged commit fbd2bef into main Aug 22, 2023
9 checks passed
@zajck zajck deleted the audit_v2_3_0_bvr_06_m branch August 24, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertfolch-redeemeum albertfolch-redeemeum albertfolch-redeemeum approved these changes

@levalleux-ludo levalleux-ludo levalleux-ludo approved these changes

Assignees

@zajck zajck

Labels
bug Something isn't working v2.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BVR-06M] Insufficient Protection of Contract Assets
4 participants
@zajck @coveralls @levalleux-ludo @albertfolch-redeemeum