Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate the twin transfer gas limits #764

Merged
merged 10 commits into from
Aug 29, 2023
Merged

Conversation

zajck
Copy link
Member

@zajck zajck commented Aug 10, 2023

Closes #757

Based on #759 which should be merged before this.

@zajck zajck self-assigned this Aug 10, 2023
@zajck zajck added the v2.3.0 label Aug 10, 2023
@coveralls
Copy link

coveralls commented Aug 10, 2023

Coverage Status

coverage: 99.582%. remained the same when pulling cc586de on twin-transfer-gas-limits into 73e00ca on main.

@zajck zajck requested review from albertfolch-redeemeum and removed request for anajuliabit August 28, 2023 13:37
Copy link
Contributor

@albertfolch-redeemeum albertfolch-redeemeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments but it looks good

scripts/util/estimate-twin-transfer-limits.js Outdated Show resolved Hide resolved
scripts/util/estimate-twin-transfer-limits.js Outdated Show resolved Hide resolved
scripts/util/estimate-twin-transfer-limits.js Show resolved Hide resolved
scripts/util/estimate-twin-transfer-limits.js Outdated Show resolved Hide resolved
scripts/util/estimate-twin-transfer-limits.js Outdated Show resolved Hide resolved
Co-authored-by: albertfolch-redeemeum <102516373+albertfolch-redeemeum@users.noreply.github.com>
Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... great documentation there

@mischat mischat merged commit 2b9f60b into main Aug 29, 2023
9 checks passed
@mischat mischat deleted the twin-transfer-gas-limits branch August 29, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estimate SINGLE_TWIN_RESERVED_GAS and MINIMAL_RESIDUAL_GAS
4 participants