Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol Fee Table #964

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Protocol Fee Table #964

wants to merge 16 commits into from

Conversation

0xlucian
Copy link
Contributor

@0xlucian 0xlucian commented Oct 1, 2024 •
edited
Loading

Fix #956

@0xlucian 0xlucian changed the title Fee Table Implementation Protocol Fee Table Oct 1, 2024
@coveralls
Copy link

coveralls commented Oct 1, 2024 •
edited
Loading

Coverage Status

coverage: 98.936% (-0.01%) from 98.948%
when pulling d9e78dc on 212-protocol-fee-table
into 6353182 on main.

zajck
zajck requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@zajck zajck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just added some suggestions for improvements.

contracts/interfaces/events/IBosonConfigEvents.sol Outdated Show resolved Hide resolved
contracts/protocol/bases/ProtocolBase.sol Outdated Show resolved Hide resolved
contracts/protocol/bases/ProtocolBase.sol Outdated Show resolved Hide resolved
contracts/protocol/bases/ProtocolBase.sol Outdated Show resolved Hide resolved
contracts/protocol/bases/ProtocolBase.sol Outdated Show resolved Hide resolved
contracts/protocol/facets/ConfigHandlerFacet.sol Outdated Show resolved Hide resolved
contracts/protocol/facets/ConfigHandlerFacet.sol Outdated Show resolved Hide resolved
contracts/protocol/facets/ConfigHandlerFacet.sol Outdated Show resolved Hide resolved
contracts/protocol/facets/ConfigHandlerFacet.sol Outdated Show resolved Hide resolved
test/protocol/ConfigHandlerTest.js Outdated Show resolved Hide resolved
@0xlucian 0xlucian requested a review from zajck October 2, 2024 11:07
zajck
zajck requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@zajck zajck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small natspec change.

contracts/protocol/facets/ConfigHandlerFacet.sol Outdated Show resolved Hide resolved
@0xlucian 0xlucian requested a review from zajck October 2, 2024 12:11
zajck
zajck previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@zajck zajck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zajck zajck zajck left review comments

@levalleux-ludo levalleux-ludo Awaiting requested review from levalleux-ludo

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protocol fee table
3 participants
@0xlucian @coveralls @zajck