Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate finance widget #609

Merged
merged 12 commits into from
Nov 27, 2023
Merged

Conversation

albertfolch-redeemeum
Copy link
Collaborator

@albertfolch-redeemeum albertfolch-redeemeum commented Nov 24, 2023

  • copy updated code of finance component from interface to here
  • add connect buttons at the top if there is no parentOrigin defined
  • disconnect wallet if connected account's seller id doesnt match the provided sellerId (similar to redemption widget)
  • if parentOrigin is defined, use signer from parent window instead

related to: bosonprotocol/interface#935
related to: bosonprotocol/widgets#94

@albertfolch-redeemeum albertfolch-redeemeum changed the title Integrate finance widget feat: integrate finance widget Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a40cd39) 84.52% compared to head (51697c2) 84.49%.
Report is 3 commits behind head on main.

❗ Current head 51697c2 differs from pull request most recent head 7ba84fb. Consider uploading reports for the commit 7ba84fb to get more accurate results

Files Patch % Lines
packages/core-sdk/src/core-sdk.ts 50.00% 1 Missing ⚠️
packages/core-sdk/src/offers/mixin.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   84.52%   84.49%   -0.04%     
==========================================
  Files         137      137              
  Lines        4071     4076       +5     
  Branches      713      716       +3     
==========================================
+ Hits         3441     3444       +3     
- Misses        630      632       +2     
Flag Coverage Δ
common 85.11% <ø> (ø)
core-sdk 50.10% <12.50%> (-0.05%) ⬇️
e2e 83.56% <75.00%> (-0.04%) ⬇️
eth-connect-sdk 18.30% <ø> (ø)
ethers-sdk 67.63% <ø> (ø)
ipfs-storage 94.02% <ø> (ø)
metadata 94.44% <ø> (ø)
unittests 53.92% <12.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertfolch-redeemeum albertfolch-redeemeum merged commit 79983d1 into main Nov 27, 2023
5 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the integrate-finance-widget branch November 27, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants