Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add listingTime and narrow down marketplace returned #829

Merged

Conversation

albertfolch-redeemeum
Copy link
Collaborator

if we want to create a listing that starts in the future then we need to set the listingTime AFAIK

also change the types in the MarketplaceMixin so it returns an OpenSeaHandler if that is the case

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (ea7969d) to head (ab55eb5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files         163      163           
  Lines        6061     6061           
  Branches      927      927           
=======================================
  Hits         5471     5471           
  Misses        590      590           
Flag Coverage Δ
common 92.11% <ø> (ø)
core-sdk 59.50% <100.00%> (ø)
e2e 87.19% <100.00%> (ø)
eth-connect-sdk 94.87% <ø> (ø)
ethers-sdk 69.62% <ø> (ø)
ipfs-storage 89.41% <ø> (ø)
metadata 94.70% <ø> (ø)
unittests 62.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertfolch-redeemeum albertfolch-redeemeum merged commit 8659149 into main Nov 8, 2024
9 of 11 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the add-listing-time-and-refactor-marketplace-mixin branch November 8, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants