Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redeemption widget without connecting wallet #966

Merged
merged 3 commits into from
Dec 13, 2023
Merged

feat: redeemption widget without connecting wallet #966

merged 3 commits into from
Dec 13, 2023

Conversation

albertfolch-redeemeum
Copy link
Contributor

@albertfolch-redeemeum albertfolch-redeemeum commented Dec 12, 2023 •
edited
Loading

@albertfolch-redeemeum albertfolch-redeemeum requested a review from a team as a code owner December 12, 2023 16:27
This was referenced Dec 12, 2023
Merged
Merged
@albertfolch-redeemeum albertfolch-redeemeum marked this pull request as draft December 12, 2023 16:29
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1ce2a9
Status: ✅  Deploy successful!
Preview URL: https://65ce4f0f.interface-a9d.pages.dev
Branch Preview URL: https://617-make-redemption-widget-a.interface-a9d.pages.dev

View logs

@albertfolch-redeemeum albertfolch-redeemeum marked this pull request as ready for review December 12, 2023 17:03
levalleux-ludo
levalleux-ludo requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@levalleux-ludo levalleux-ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working when I click Redeem on the Exchange Details page.
However it also needs to be changed for the Cancel button in the same page +
when clicking Redeem/Cancel on the ExchangeCard

interface/src/components/exchange/Exchange.tsx

Line 167 in 7416f7f

window.bosonWidgetShowRedeem({

@albertfolch-redeemeum albertfolch-redeemeum merged commit fcc6fd8 into main Dec 13, 2023
9 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the 617-make-redemption-widget-able-to-use-parent-iframe-walletsigner-so-you-dont-need-to-connect-your-wallet-again branch December 13, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levalleux-ludo levalleux-ludo levalleux-ludo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertfolch-redeemeum @levalleux-ludo