Skip to content

Commit

Permalink
Merge pull request #142 from bosonprotocol/tagline-commit-button-mand…
Browse files Browse the repository at this point in the history
…atory

refactor: tagline is mandatory in commit button
  • Loading branch information
albertfolch-redeemeum authored Apr 17, 2024
2 parents a8f093b + 2f5ccc7 commit 35ba87d
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 20 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@bosonprotocol/react-kit": "^0.29.1",
"@bosonprotocol/react-kit": "^0.30.0-alpha.1",
"@krakenjs/zoid": "^10.3.3",
"@svgr/webpack": "^8.1.0",
"@testing-library/jest-dom": "^5.16.5",
Expand Down
1 change: 0 additions & 1 deletion public/scripts/commit-button-example.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ <h3>Commit button example</h3>
modalMargin: "2%",
lookAndFeel: "modal",
disabled: false,
tagline: true,
buttonStyle: {
minWidth: "100px",
minHeight: "200px",
Expand Down
19 changes: 5 additions & 14 deletions src/components/widgets/commitButton/CommitButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -104,20 +104,11 @@ export function CommitButton() {
"iframe"
);
}}
{...(props.tagline
? {
tagline: true,
onTaglineClick: () => {
PurchaseOverviewModal({
modalMargin
}).renderTo(
window.parent,
renderToSelector || "body",
"iframe"
);
}
}
: { tagline: false })}
onTaglineClick={() => {
PurchaseOverviewModal({
modalMargin
}).renderTo(window.parent, renderToSelector || "body", "iframe");
}}
/>
</>
);
Expand Down

0 comments on commit 35ba87d

Please sign in to comment.