fix(indexing)!: Node ID no longer memoized #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonv
changed the title
timonv
changed the title
This was referenced Oct 27, 2024
Closed
Merged
timonv
pushed a commit
that referenced
this pull request
Oct 27, 2024
## 🤖 New release * `swiftide`: 0.13.4 -> 0.14.0 (✓ API compatible changes) * `swiftide-core`: 0.13.4 -> 0.14.0 (⚠️ API breaking changes) * `swiftide-indexing`: 0.13.4 -> 0.14.0 (✓ API compatible changes) * `swiftide-macros`: 0.13.4 -> 0.14.0 * `swiftide-integrations`: 0.13.4 -> 0.14.0 (✓ API compatible changes) * `swiftide-query`: 0.13.4 -> 0.14.0 (✓ API compatible changes) ###⚠️ `swiftide-core` breaking changes ``` --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/inherent_method_missing.ron Failed in: Node::update_id, previously in file /tmp/.tmpp9ZuUf/swiftide-core/src/node.rs:204 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/struct_pub_field_missing.ron Failed in: field id of struct Node, previously in file /tmp/.tmpp9ZuUf/swiftide-core/src/node.rs:41 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `swiftide` <blockquote> ## [0.14.0](v0.13.4...v0.14.0) - 2024-10-27 ### New features - [a866d38](a866d38) *(integrations)* Support in process hugging face models via mistralrs ([#386](#386)) ### Bug fixes - [551a9cb](551a9cb) *(indexing)* [**breaking**] Node ID no longer memoized ([#414](#414)) ````text As @shamb0 pointed out in [#392](#392), there is a potential issue where Node ids are get cached before chunking or other transformations, breaking upserts and potentially resulting in data loss. ```` **BREAKING CHANGE**: This PR reworks Nodes with a builder API and a private id. Hence, manually creating nodes no longer works. In the future, all the fields are likely to follow the same pattern, so that we can decouple the inner fields from the Node's implementation. - [c091ffa](c091ffa) *(indexing)* Use atomics for key generation in memory storage ([#415](#415)) ### Miscellaneous - [0000000](0000000) Update Cargo.toml dependencies **Full Changelog**: 0.13.4...0.14.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
shamb0
pushed a commit
to shamb0/swiftide
that referenced
this pull request
Oct 30, 2024
As @shamb0 pointed out in bosun-ai#392, there is a potential issue where Node ids are get cached before chunking or other transformations, breaking upserts and potentially resulting in data loss. BREAKING CHANGE: This PR reworks Nodes with a builder API and a private id. Hence, manually creating nodes no longer works. In the future, all the fields are likely to follow the same pattern, so that we can decouple the inner fields from the Node's implementation.
shamb0
pushed a commit
to shamb0/swiftide
that referenced
this pull request
Oct 30, 2024
## 🤖 New release * `swiftide`: 0.13.4 -> 0.14.0 (✓ API compatible changes) * `swiftide-core`: 0.13.4 -> 0.14.0 (⚠️ API breaking changes) * `swiftide-indexing`: 0.13.4 -> 0.14.0 (✓ API compatible changes) * `swiftide-macros`: 0.13.4 -> 0.14.0 * `swiftide-integrations`: 0.13.4 -> 0.14.0 (✓ API compatible changes) * `swiftide-query`: 0.13.4 -> 0.14.0 (✓ API compatible changes) ###⚠️ `swiftide-core` breaking changes ``` --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/inherent_method_missing.ron Failed in: Node::update_id, previously in file /tmp/.tmpp9ZuUf/swiftide-core/src/node.rs:204 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/struct_pub_field_missing.ron Failed in: field id of struct Node, previously in file /tmp/.tmpp9ZuUf/swiftide-core/src/node.rs:41 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `swiftide` <blockquote> ## [0.14.0](bosun-ai/swiftide@v0.13.4...v0.14.0) - 2024-10-27 ### New features - [a866d38](bosun-ai@a866d38) *(integrations)* Support in process hugging face models via mistralrs ([bosun-ai#386](bosun-ai#386)) ### Bug fixes - [551a9cb](bosun-ai@551a9cb) *(indexing)* [**breaking**] Node ID no longer memoized ([bosun-ai#414](bosun-ai#414)) ````text As @shamb0 pointed out in [bosun-ai#392](bosun-ai#392), there is a potential issue where Node ids are get cached before chunking or other transformations, breaking upserts and potentially resulting in data loss. ```` **BREAKING CHANGE**: This PR reworks Nodes with a builder API and a private id. Hence, manually creating nodes no longer works. In the future, all the fields are likely to follow the same pattern, so that we can decouple the inner fields from the Node's implementation. - [c091ffa](bosun-ai@c091ffa) *(indexing)* Use atomics for key generation in memory storage ([bosun-ai#415](bosun-ai#415)) ### Miscellaneous - [0000000](bosun-ai@0000000) Update Cargo.toml dependencies **Full Changelog**: bosun-ai/swiftide@0.13.4...0.14.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @shamb0 pointed out in #392, there is a potential issue where Node ids are get cached before chunking or other transformations, breaking upserts and potentially resulting in data loss.
BREAKING CHANGE: This PR reworks Nodes with a builder API and a private id. Hence, manually creating nodes no longer works. In the future, all the fields are likely to follow the same pattern, so that we can decouple the inner fields from the Node's implementation.