Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move invert3x3 out of general purpose utils.hxx header #3018

Merged
merged 11 commits into from
Nov 26, 2024
Merged

Move invert3x3 out of general purpose utils.hxx header #3018

merged 11 commits into from
Nov 26, 2024

Commits on Oct 30, 2024

  1. Move invert3x3 out of general purpose utils.hxx header 

    Only used in `Coordinates`, so make private implementation detail
    @ZedThree
    ZedThree committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e594a89 View commit details
    Browse the repository at this point in the history

  2. Return bool instead of int from invert3x3

    @ZedThree
    ZedThree committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6e839d6 View commit details
    Browse the repository at this point in the history

  3. Apply clang-format changes

    @ZedThree @github-actions
    ZedThree authored and github-actions[bot] committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a7114c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Return std::optional from invert3x3 

    Allows throwing more specific error in coordinates
    @ZedThree
    ZedThree committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1aa0e23 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. simplify return statement

    @dschwoerer
    dschwoerer authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d6aa81f View commit details
    Browse the repository at this point in the history

  2. Use formatter for SpecificInd 

    This works for 2D and 3D fields (and is also shorter code)
    @dschwoerer
    dschwoerer authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e70fb7a View commit details
    Browse the repository at this point in the history

  3. Apply clang-format changes

    @dschwoerer @github-actions
    dschwoerer authored and github-actions[bot] committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    12292e8 View commit details
    Browse the repository at this point in the history

  4. Add missing header to format SpecificInd

    @dschwoerer
    dschwoerer committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    00a156d View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/next' into move-invert3x3

    @dschwoerer
    dschwoerer committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    68512de View commit details
    Browse the repository at this point in the history

  6. Apply clang-format changes

    @dschwoerer @github-actions
    dschwoerer authored and github-actions[bot] committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    f6f78f6 View commit details
    Browse the repository at this point in the history

  7. Prefere const

    @dschwoerer
    dschwoerer committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    5a60a52 View commit details
    Browse the repository at this point in the history