Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add create sign request function with different required parameters #878

Merged
merged 8 commits into from
Jul 10, 2024
Merged

feat: add create sign request function with different required parameters #878

merged 8 commits into from
Jul 10, 2024

Conversation

mwwoda
Copy link
Contributor

@mwwoda mwwoda commented Jul 10, 2024

Some of the params (parent_folder_id and files) are no longer required since box/box-openapi@797a90d

@mwwoda mwwoda changed the title feat: add create sign request function with different required params feat: add create sign request function with different required parameters Jul 10, 2024
@coveralls
Copy link

coveralls commented Jul 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9876799947

Details

  • 29 of 37 (78.38%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.584%
Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/client/client.py 29 37 78.38%
Totals Coverage Status
Change from base Build 9837232680: 0.02%
Covered Lines: 3515
Relevant Lines: 3756
💛 - Coveralls

lukaszsocha2
lukaszsocha2 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@lukaszsocha2 lukaszsocha2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge if build is green

@mwwoda mwwoda merged commit d972f54 into main Jul 10, 2024
13 checks passed
@mwwoda mwwoda deleted the expose-create-sign-request-with-different-params branch July 10, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszsocha2 lukaszsocha2 lukaszsocha2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwwoda @coveralls @lukaszsocha2