This repository has been archived by the owner on Jun 27, 2024. It is now read-only.
refactor(ext/files): respect index.html and 404.html files
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: files ext now look for index.html if no file is specified feat: files ext now look for 404.html if file could not be found
|
@not-ivy i'd suggest to split this pr into 3 smaller ones as it's better to have one (major) change per commit. |
|
...or at least 2, one for the s3 functionality and the other one for the html files lookup |
boywithkeyboard
suggested changes
Aug 23, 2023
boywithkeyboard
changed the title
index.html and 404.html files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: files ext now look for index.html if no file is specified
feat: files ext now look for 404.html if file could not be found