-
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
…he body tag, allowing for head meta tags and such to be injected and handled by the browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jaymanmdev seems like the test suite failed because of the changes you made. Please read the test file and try to fix the issue. |
Other than that, I like the idea behind this pr! :) |
…d expected initially.
…ightly change render body assignment to not inject empty style tag if twind isn't utilised.
Sorry, this is my first ever PR in any repo so I am still getting the hang of it, I'm getting in the habit of running the tests before submitting an adjustment to my PR/s from now on. Thanks! Edit: I can merge the two render tests together later on if that would be preferred. :) |
Our contributing guidelines are really basic but that's the one thing that's included in them. 😅 |
Ah, I didn't pick up on that guidelines file - my bad! I tested the suite this time though. |
Just make a sub-test, e.g. Deno.test('something', async (t) => {
await t.step('first step', async () => {
// some code
})
}) |
I'll quickly do this now, and submit an adjustment. |
…ut Twind styling to test for empty style tag injection, and 1 to test for meta tag injection in head.)
…d of slicing the HEAD_TAG constant. (changes requested by not-ivy)
… css from Twind straight away, and return the html as is without any changes if that is the case)
… or body tags to ensure that the browser and document is still generated appropriately, remove the head manipulation in the render function as the browser will usually know where to put specific tags upon request.
Let me know what you think.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
update the JSX render class to not explicitly inject HTML inside of the body tag, allowing for head meta tags and such to be injected and handled by the browser.