This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Add device capabilities and read humidity sensor #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 99.95% 99.80% -0.15%
==========================================
Files 107 108 +1
Lines 2056 2062 +6
==========================================
+ Hits 2055 2058 +3
- Misses 1 4 +3
Continue to review full report at Codecov.
|
|
Ok, might need to add a few trivial tests in device.go. Should I do that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in FritzOS 7.25, the AVM FRITZ!DECT 440 can read the humidity of its surroundings. I have added the relevant code to include it in the library (although not in the command line tool - might be a bit longish and the 440 is not shown on thermostat temperature readouts anyway).
I also expanded the list of device capabilities I found in the official AVM documentation.
I would be happy if you accpted the pull request.