fix: support rendering of gateway without marker

bpmn-io · Feb 15, 2024 · b100cdf · b100cdf
1 parent 88b201a
commit b100cdf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/lib/features/modeling/ElementFactory.js b/lib/features/modeling/ElementFactory.js
@@ -216,11 +216,9 @@ ElementFactory.prototype.createElement = function(elementType, attrs) {
   }
 
   if (is(businessObject, 'bpmn:ExclusiveGateway')) {
-    if (has(attrs, 'isMarkerVisible')) {
-      if (attrs.isMarkerVisible === undefined) {
+    if (has(di, 'isMarkerVisible')) {
+      if (di.isMarkerVisible === undefined) {
         di.isMarkerVisible = false;
-      } else {
-        attrs = applyAttribute(di, attrs, 'isMarkerVisible');
       }
     } else {
       di.isMarkerVisible = true;

diff --git a/lib/features/palette/PaletteProvider.js b/lib/features/palette/PaletteProvider.js
@@ -172,8 +172,7 @@ PaletteProvider.prototype.getPaletteEntries = function() {
     ),
     'create.exclusive-gateway': createAction(
       'bpmn:ExclusiveGateway', 'gateway', 'bpmn-icon-gateway-none',
-      translate('Create gateway'),
-      { isMarkerVisible: true }
+      translate('Create gateway')
     ),
     'create.task': createAction(
       'bpmn:Task', 'activity', 'bpmn-icon-task',

diff --git a/test/spec/features/modeling/ElementFactorySpec.js b/test/spec/features/modeling/ElementFactorySpec.js
@@ -212,7 +212,7 @@ describe('features - element factory', function() {
       // when
       var shape = elementFactory.createShape({
         type: 'bpmn:ExclusiveGateway',
-        isMarkerVisible: true
+        di: { isMarkerVisible: true }
       });
 
       // then
@@ -225,7 +225,7 @@ describe('features - element factory', function() {
       // when
       var shape = elementFactory.createShape({
         type: 'bpmn:ExclusiveGateway',
-        isMarkerVisible: false
+        di: { isMarkerVisible: false }
       });
 
       // then