Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(copy-paste): fix default sequence flow default propertie are not enumerable #1936

Closed
wants to merge 2 commits into from
Closed

fix(copy-paste): fix default sequence flow default propertie are not enumerable #1936

wants to merge 2 commits into from

Conversation

ChaominRuan
Copy link
Contributor

Closes #1935

@nikku
Copy link
Member

nikku commented Aug 7, 2023

@ChaominRuan Great contribution! Do you mind adding a test case that verifies the behavior?

@ChaominRuan
Copy link
Contributor Author

ChaominRuan commented Aug 7, 2023 •
edited
Loading

@ChaominRuan Great contribution! Do you mind adding a test case that verifies the behavior?

I haven't written a test case, I can try to write one.

@ChaominRuan
Copy link
Contributor Author

@nikku I added an expect to the “should copy conditional and default flow properties” test case.

@philippfromme
Copy link
Contributor

Fixed by ca65cde. The simple solution was to use set instead of assignment. Thank you for discovering this bug and contributing! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with references after copying default sequence flow elements
3 participants
@ChaominRuan @nikku @philippfromme