fix(outline): external label resize #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smbea
force-pushed
the
update-label-outline
branch
from
d11e7f8
to
ee8bb5b
Compare
smbea
force-pushed
the
update-label-outline
branch
from
ee8bb5b
to
52df3b3
Compare
bpmn-io-tasks
bot
added
needs review
smbea
requested review from
barmac,
a team and
marstamm
and removed request for
a team
barmac
reviewed
Nov 3, 2023
| expect(bounds.height).to.be.closeTo(24, DELTA); | ||
|
|
||
| // when | ||
| modeling.updateLabel(externalLabel, 'fooooooooooooooo'); |
|
Changing target to |
barmac
approved these changes
Nov 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2001