Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement basic filepicker on viewer #1245

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

vsgoulart
Copy link
Contributor

Related to 1239 #

  • This PR adds a new form-js element or visually changes an existing component.

@vsgoulart vsgoulart requested a review from Skaiir August 23, 2024 08:30
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 23, 2024
Copy link
Contributor

@Skaiir Skaiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things I noted, aside from that looks good. Fix now or later at your discretion.

@vsgoulart vsgoulart merged commit 5719014 into 1239-file-input-element Aug 23, 2024
11 of 12 checks passed
@vsgoulart vsgoulart deleted the 1239-basic-viewer branch August 23, 2024 14:23
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants