Add .js extensions to d.ts exports #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benasher44
added a commit
to benasher44/min-dash
that referenced
this pull request
Jan 9, 2024
|
I'm on, trying to merge this 🤞. |
benasher44
force-pushed
the
basher/js-extensions
branch
from
5f8c9f7
to
8f0a4b3
Compare
|
Updated with main now that #32 has landed — CI should pass now |
nikku
force-pushed
the
basher/js-extensions
branch
from
8f0a4b3
to
3de2d5f
Compare
|
I added some additional validation for strict and ESM modes via 1a8f5c9. |
nikku
force-pushed
the
basher/js-extensions
branch
from
3de2d5f
to
b1bec1c
Compare
This allows users to consume the type definitions in ESM setups.
nikku
force-pushed
the
basher/js-extensions
branch
from
b1bec1c
to
dc90fe7
Compare
|
Works on CI ™️ |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one of the core issues in #28