feat: workaround isEdited race condition

Related to camunda/camunda-modeler#3815
bpmn-io · Sep 25, 2023 · 9f8373c · 9f8373c
1 parent 52bd8dd
commit 9f8373c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 13 deletions.
diff --git a/src/components/Group.js b/src/components/Group.js
@@ -58,25 +58,29 @@ export default function Group(props) {
 
   // set edited state depending on all entries
   useEffect(() => {
-    const hasOneEditedEntry = entries.find(entry => {
-      const {
-        id,
-        isEdited
-      } = entry;
+    const scheduled = requestAnimationFrame(() => {
+      const hasOneEditedEntry = entries.find(entry => {
+        const {
+          id,
+          isEdited
+        } = entry;
 
-      const entryNode = domQuery(`[data-entry-id="${id}"]`);
+        const entryNode = domQuery(`[data-entry-id="${id}"]`);
 
-      if (!isFunction(isEdited) || !entryNode) {
-        return false;
-      }
+        if (!isFunction(isEdited) || !entryNode) {
+          return false;
+        }
+
+        const inputNode = domQuery('.bio-properties-panel-input', entryNode);
 
-      const inputNode = domQuery('.bio-properties-panel-input', entryNode);
+        return isEdited(inputNode);
+      });
 
-      return isEdited(inputNode);
+      setEdited(hasOneEditedEntry);
     });
 
-    setEdited(hasOneEditedEntry);
-  }, [ entries ]);
+    return () => cancelAnimationFrame(scheduled);
+  }, [ entries, setEdited ]);
 
   // set error state depending on all entries
   const allErrors = useErrors();

diff --git a/test/spec/components/Group.spec.js b/test/spec/components/Group.spec.js
@@ -43,6 +43,11 @@ describe('<Group>', function() {
     container = TestContainer.get(this);
   });
 
+  beforeEach(() => {
+    const requestAnimationFrameSpy = sinon.fake.returns(cb => cb());
+    global.window.requestAnimationFrame = requestAnimationFrameSpy();
+  });
+
 
   it('should render', function() {