Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag trap for popups #292

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Drag trap for popups #292

merged 4 commits into from
Sep 26, 2023

Commits on Sep 26, 2023

  1. style: set popup position to fixed

    Niklas Kiefer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2d7f3c0 View commit details
    Browse the repository at this point in the history

  2. fix(popup): trap drag events inside popup 

    * Do not bubble up dragstart events
* Do not bubble up dragover events
    Niklas Kiefer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    ead4dcc View commit details
    Browse the repository at this point in the history

  3. fix(util/dragger): handle dragover events during capture phase 

    We need to do this to make sure we track cursor movements before we reach other drag event handlers, e.g. in child containers.

Related to #289
Related to https://github.com/camunda/web-modeler/issues/5892#issuecomment-1733155870
    Niklas Kiefer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0694e2f View commit details
    Browse the repository at this point in the history

  4. feat(feel-popup): fire dragging events 

    Closes #289
    Niklas Kiefer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d6feb96 View commit details
    Browse the repository at this point in the history