Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: focus offset added for checkbox and buttons #390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: focus offset added for checkbox and buttons #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/assets/properties-panel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
--color-blue-205-100-35: hsl(205, 100%, 35%);
--color-blue-205-100-45: hsl(205, 100%, 45%);
--color-blue-205-100-50: hsl(205, 100%, 50%);
--color-blue-205-100-40: hsl(205, 100%, 40%);
--color-blue-205-100-85: hsl(205, 100%, 85%);
--color-blue-205-100-95: hsl(205, 100%, 95%);
--color-blue-219-99-53: hsl(219, 99%, 53%);
Expand Down Expand Up @@ -78,6 +79,7 @@

--input-focus-background-color: var(--color-blue-205-100-95);
--input-focus-border-color: var(--color-blue-205-100-50);
--focus-outline-color: var(--color-blue-205-100-40);

--input-error-background-color: var(--color-red-360-100-97);
--input-error-border-color: var(--color-red-360-100-45);
Expand Down Expand Up @@ -299,6 +301,10 @@
background: none;
}

.bio-properties-panel-group-header-button:focus {
outline-offset: 2px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outline still black for me:

brave_gxcOzPHfJA

Suggestion:

Suggested change
outline-offset: 2px;
outline-offset: 2px;
outline-color: var(--focus-outline-color);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange, it's already showing blue for me. Are you linking the library to bpmn-js-properties-panel to verify the changes?

Even before my updates, the outline was already blue; I only added the offset. Could you double-check? I want to avoid adding redundant properties.

}

.bio-properties-panel-group-header-buttons .bio-properties-panel-group-header-buttons:last-child {
margin-right: 0;
}
Expand Down Expand Up @@ -537,8 +543,9 @@ select.bio-properties-panel-input {
}

.bio-properties-panel-input[type="checkbox"]:focus {
outline: 2px solid var(--input-focus-border-color);
outline-offset: 0;
outline: auto;
outline-color: var(--focus-outline-color);
outline-offset: 2px;
}

.bio-properties-panel-checkbox > .bio-properties-panel-label {
Expand Down