Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tqdm.auto.tqdm for optimal progressbars display #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bqth29
Copy link
Owner

@bqth29 bqth29 commented Oct 15, 2024

💬 Pull Request Description

Though the progressbars display was optimized for terminals, they appeared oddly in Jupyter notebooks with the same progressbar being displayed again and again each time it was updated.

Using from tqdm.auto import tqdm instead of from tqdm import tqdm fixed this and the display in notebooks is better visually.

✔️ Check list

  • The code matches the styling rules
  • The new code is covered by relevant tests
  • Documentation was added

🚀 New features

None.

🐞 Bug fixes

Bad progressbars display in Jupyter notebooks.

📣 Supplementary information

None.

@bqth29 bqth29 added the bug Something isn't working label Oct 15, 2024
@bqth29 bqth29 changed the title Use tqdm.auto for optimal progressbars display Use tqdm.auto.tqdm for optimal progressbars display Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a9ab8bb) to head (a52f85a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1600      1600           
=========================================
  Hits          1600      1600           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant