Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: change font-family to improve UI #501

Closed
wants to merge 1 commit into from
Closed

New: change font-family to improve UI #501

wants to merge 1 commit into from

Conversation

OshriAsulin
Copy link
Contributor

@OshriAsulin OshriAsulin commented Sep 21, 2023 •
edited
Loading

In this PR I made my first contribution to this important project.
I changed the font-family to improve the UI.

This PR is addressed to issue #500

Screenshots before and after changes:

Before
צילום מסך 2023-09-21 062042

After
צילום מסך 2023-09-21 062015

@baruchiro
Copy link
Collaborator

@brafdlog Is it the design?

@brafdlog
Copy link
Owner

I am fine with the change.
Its pretty minor.
But the build is not passing

@OshriAsulin
Copy link
Contributor Author

I am fine with the change. Its pretty minor. But the build is not passing

Why the build isn't passing? Is it something that I need to do?

@baruchiro
Copy link
Collaborator

No, usually we have problems with the build

@baruchiro baruchiro changed the title change font-family in electron for improve UI patch: change font-family in electron for improve UI Sep 21, 2023
@baruchiro baruchiro changed the title patch: change font-family in electron for improve UI patch: change font-family to improve UI Sep 21, 2023
@baruchiro baruchiro changed the title patch: change font-family to improve UI New: change font-family to improve UI Sep 21, 2023
@OshriAsulin
Copy link
Contributor Author

No, usually we have problems with the build

Ok, so you want I open on this bug new issue?
I don't sure that I can resolve this issue, but I can to try...

@baruchiro
Copy link
Collaborator

You don't need to do something, I'm on it

@baruchiro
Copy link
Collaborator

@OshriAsulin Please update your branch with the master (git fetch --all && git merge origin/master)

@baruchiro baruchiro mentioned this pull request Dec 3, 2023
Merged
baruchiro added a commit that referenced this pull request Dec 4, 2023
@baruchiro @OshriAsulin
New: change font-family to improve UI (#517)
5f3c6ca 
Copy of #501, see there

Close #501
Close #500

Co-authored-by: Oshri Asulin <oshri12120@gmail.com>
github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@semantic-release-bot
chore(release): 1.15.0 [skip ci]
8a97bba 
# [1.15.0](v1.14.1...v1.15.0) (2023-12-04)

### New

* change font-family to improve UI (#517) ([5f3c6ca](5f3c6ca)), closes [#517](#517) [#501](#501) [#501](#501) [#500](#500)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baruchiro baruchiro baruchiro approved these changes

@brafdlog brafdlog Awaiting requested review from brafdlog

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OshriAsulin @baruchiro @brafdlog