Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single char wait time after flush to avoid RTU control pin timing issue #79

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add single char wait time after flush to avoid RTU control pin timing issue #79

merged 1 commit into from
Jul 19, 2023

Conversation

brainelectronics
Copy link
Owner

Fixed

@brainelectronics brainelectronics added the bug Something isn't working label Jul 19, 2023
@brainelectronics brainelectronics self-assigned this Jul 19, 2023
@brainelectronics brainelectronics force-pushed the bugfix/yet-another-ctrl-pin-timing-issue branch from 08670e6 to 9fb326c Compare July 19, 2023 20:53
@brainelectronics
Copy link
Owner Author

TIL: Practice what you preach, install the precommit hooks, you can't always force push

brainelectronics
brainelectronics commented Jul 19, 2023
View reviewed changes
Copy link
Owner Author

@brainelectronics brainelectronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMyself, of course

@brainelectronics brainelectronics merged commit e9ab05a into develop Jul 19, 2023
@brainelectronics brainelectronics deleted the bugfix/yet-another-ctrl-pin-timing-issue branch July 19, 2023 20:57
@brainelectronics brainelectronics mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brainelectronics brainelectronics

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brainelectronics