Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for os.arch when unpacking MLModel .dlls on WIndows #679

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add check for os.arch when unpacking MLModel .dlls on WIndows #679

merged 2 commits into from
Oct 26, 2023

Conversation

retiutut
Copy link
Member

@retiutut retiutut commented Oct 13, 2023 •
edited
Loading

@Andrey1994 This change will cleanup the console log for all BrainFlow users who work with Java, including OpenBCI Public GUI and Galea GUI.

Currently, an error is thrown every time the MLModel class is instantiated.

Andrey1994
Andrey1994 reviewed Oct 15, 2023
View reviewed changes
Copy link
Member

@Andrey1994 Andrey1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! lets replace exception by stderr since its an optional dependency and unpacking itself can be optional too

@retiutut retiutut requested a review from Andrey1994 October 26, 2023 18:12
@Andrey1994 Andrey1994 merged commit 8305c60 into brainflow-dev:master Oct 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrey1994 Andrey1994 Awaiting requested review from Andrey1994

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retiutut @Andrey1994