-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added praire vole file #336
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
ATLAS_BASE_URL = "https://ndownloader.figshare.com/files/" | ||
ORIENTATION = "..." | ||
ROOT_ID = 997 | ||
ATLAS_PACKAGER = "..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add your name here.
|
||
|
||
def create_atlas(working_dir): | ||
ATLAS_NAME = "..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've emailed the lab that originally made this atlas to see if they have a preference for the name, but for now it can just be prairie_vole_brain
.
|
||
def create_atlas(working_dir): | ||
ATLAS_NAME = "..." | ||
SPECIES = "..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be Microtus ochrogaster
def create_atlas(working_dir): | ||
ATLAS_NAME = "..." | ||
SPECIES = "..." | ||
ATLAS_LINK = "https://elifesciences.org/articles/87029#data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be Gustison et al. 2024, https://doi.org/10.7554/eLife.87029
ATLAS_LINK = "https://elifesciences.org/articles/87029#data" | ||
CITATION = "..." | ||
ATLAS_BASE_URL = "https://ndownloader.figshare.com/files/" | ||
ORIENTATION = "..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the orientation of the raw data (before packaging), and should be asr
. Details here if you're interested.
) | ||
|
||
with zipfile.ZipFile( | ||
r"C:\Users\sacha\Downloads\atlas shit\PrV_results_datasets.zip", "r" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a relative path, defined by Pathlib so it will work on any system, e.g. atlas_path / "PrV_results_datasets.zip"
decimate_fraction = 0.2 | ||
smooth = False # smooth meshes after creation | ||
start = time.time() | ||
if PARALLEL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our parallel mesh extraction is broken, so all of this part can be removed, and just keep the stuff after else:
.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
What does this PR do?
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.
Checklist: