Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command-line entry point and simplify pyproject.toml #185

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

adamltyson
Copy link
Member

There were many napari-related entry points in the pyproject.toml. I think these aren't needed, so I've streamlined them.

@adamltyson adamltyson requested a review from a team July 15, 2024 11:13
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing the "napari.plugin" part, I think, and the renaming.

I am slightly unsure about removing project.scripts... because IIUC this removes a command line entry point that opens napari with the brainglobe-segmentation widget. AFAICT this CLI tool is undocumented (and hopefully not widely used), so we can remove it, but we should mention in this PR that we do so (which I have hereby done), and I wanted to double-check this removal was intended?

If this was intended, should we also remove the main function from segment.py as it's now unused, or document that your can do python segment.py to spin up napari with bg-segmentation?

@adamltyson
Copy link
Member Author

I forgot we had that CLI entry point, it's from the dark days before napari had plugins! I've removed it and amended the PR title.

@adamltyson adamltyson changed the title Simplify pyproject.toml Remove command-line entry point and simplify pyproject.toml Jul 17, 2024
@adamltyson
Copy link
Member Author

I've re-requested your review, just in case I've done something daft.

@alessandrofelder alessandrofelder merged commit 9bbff0b into main Jul 17, 2024
14 checks passed
@alessandrofelder alessandrofelder deleted the pyproject branch July 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants