Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added xfail to tests that fail due to logging bug #444

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Tests are failing due to an issue outside of cellfinder. The test failure are uninformative about the state of cellfinder.

What does this PR do?
Add xfail to all tests that fail for the issue disucessed in #443

References

#443

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Tested locally.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • [] Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review July 19, 2024 10:39
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alessandrofelder alessandrofelder merged commit 2536bea into main Jul 19, 2024
17 of 18 checks passed
@alessandrofelder alessandrofelder deleted the fix-napari-tests branch July 19, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants