Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily depend on numpy<2 #448

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Training currently fails because of keras and nump

What does this PR do?

Temporarily pin to numpy < 2

References

Workaround for #446

How has this PR been tested?

Locally, as described in #446

Is this a breaking change?

Nope

Does this PR require an update to the documentation?

Nope

Checklist:

  • The code has been tested locally
  • [ \ ] Tests have been added to cover all new functionality (unit & integration)
  • [ \ ] The documentation has been updated to reflect any changes
  • [ \ ] The code has been formatted with pre-commit

@IgorTatarnikov IgorTatarnikov self-requested a review August 7, 2024 12:08
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@IgorTatarnikov IgorTatarnikov merged commit f505db5 into main Aug 7, 2024
16 of 17 checks passed
@IgorTatarnikov IgorTatarnikov deleted the depend-on-older-numpy branch August 7, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants