Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content-part encoding and decoding for Google API. #212

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Fix content-part encoding and decoding for Google API. #212

merged 6 commits into from
Dec 12, 2024

Conversation

vkryukov
Copy link
Contributor

It also makes the JSON response parsing in the image processing notebook more robust by including explicit regex to strip json-with-trip-quotes from the beginning and the end of the model output, which seems to be a popular way across different LLMs to return a requested JSON.

Fix #209, fix #208.

@vkryukov vkryukov mentioned this pull request Dec 11, 2024
Closed
brainlid
brainlid approved these changes Dec 12, 2024
View reviewed changes
Copy link
Owner

@brainlid brainlid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the additional tests as well.

@brainlid brainlid merged commit 693e918 into brainlid:main Dec 12, 2024
1 check passed
@brainlid
Copy link
Owner

Thanks for the additional Google Gemini fixes!

❤️💛💙💜

@vkryukov
Copy link
Contributor Author

You are very welcome! Thanks for writing LangChain - I have only started using it recently, and I'm finding it indispensable already. Sorry for the barrage of issues and PRs :), but they are all coming from a place of gratitude.

@vkryukov vkryukov deleted the fix-json-processor branch December 13, 2024 00:23
brainlid added a commit that referenced this pull request Dec 15, 2024
@brainlid
Merge branch 'main' into me-summarize-conversation
d6e36c4 
* main:
  Azure test for ChatOpenAI usage
  added documentation for ChatOpenAI use on Azure
  Fix specs and examples (#211)
  Fix content-part encoding and decoding for Google API. (#212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainlid brainlid brainlid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vkryukov @brainlid