Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix walmart redirect in https://github.com/brave/brave-browser/issues/32229 #1279

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Aug 21, 2023

Address brave/brave-browser#32229

From @ShivanKaul

Okay, it’s the sod cookie set by www.walmart.com. If I use an extension to prevent the cookie from being received via Set-Cookie response, the website works correctly.
With GPC on, by default, it’s set to be torbit, if it’s set to be 0, then it works fine
I added a Sec GPC extension for Chrome and tested Walmart on that, and noticed that once the GPC header was sent once, the website remembered it and redirected even when the header was not sent, which pointed to some sort of state. I verified that by deleting session and local storage, but only after deleting all cookies did it work correctly.

We need to remove the previous "sod" cookie, otherwise it will still redirect. In the near future we could probably remove the cookie deletion.

@ryanbr ryanbr added the GPC Related globalprivacycontrol label Aug 21, 2023
@ryanbr ryanbr self-assigned this Aug 21, 2023
@ryanbr ryanbr merged commit c67badc into master Aug 21, 2023
@ryanbr ryanbr deleted the fix-walma branch August 21, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GPC Related globalprivacycontrol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant