Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atinternet params to clean-urls #1283

Merged
merged 2 commits into from
Aug 26, 2023
Merged

Add atinternet params to clean-urls #1283

merged 2 commits into from
Aug 26, 2023

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Aug 23, 2023 •
edited by fmarier
Loading

@ryanbr ryanbr added the Clean URLS Clean URL's filters label Aug 23, 2023
@ryanbr ryanbr requested a review from fmarier August 23, 2023 22:27
@ryanbr ryanbr self-assigned this Aug 23, 2023
fmarier
fmarier requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This would be easier to review if the params were sorted alphabetically.

It looks like this one is missing: at_send_date

@ryanbr
Copy link
Collaborator Author

ryanbr commented Aug 24, 2023

Okay, looks good sorted and added at_send_date

@ryanbr ryanbr requested a review from fmarier August 24, 2023 23:24
@ryanbr ryanbr merged commit 01aad33 into master Aug 26, 2023
4 checks passed
@ryanbr ryanbr deleted the fix-at-copy-cl branch August 26, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarier fmarier fmarier approved these changes

Assignees

@ryanbr ryanbr

Labels
Clean URLS Clean URL's filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanbr @fmarier