Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Ad-shield rules #2002

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Disable Ad-shield rules #2002

merged 1 commit into from
Aug 27, 2024

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Aug 27, 2024

Disable Ad-shield rules

Also add exceptions for /loader.min.js

Disable for now, for testing on ios.

@ryanbr ryanbr self-assigned this Aug 27, 2024
Copy link

[puLL-Merge] - brave/adblock-lists@2002

Description

This pull request modifies the brave-ios-specific.txt file in the Brave adblock-lists repository. The changes primarily involve commenting out or removing various adblocking rules related to the html-load.com domain and associated scripts. Some rules for specific websites are also modified or removed.

Possible Issues

  1. Commenting out or removing these adblocking rules may result in increased ad visibility on certain websites, potentially impacting user experience.
  2. The changes might lead to the reappearance of previously blocked tracking or analytics scripts on some websites.
Changes

Changes

  1. brave-lists/brave-ios-specific.txt:

    • Multiple rules targeting html-load.com and its subdomains are commented out.
    • Several domain-specific rules using ##+js(set-local-storage-item, ...) are commented out.
    • Rules applying Content Security Policy (CSP) restrictions are commented out.
    • Various allow rules (@@) for specific scripts and domains are commented out.
    • Several redirect rules for frames, scripts, and images are commented out.
    • Rules using ##+js(rmnt, script, ...) for various domains are commented out.
  2. Some rules remain active:

    • The exception rule for cmp.uniconsent.com on photopea.com is kept.
    • The rule @@/loader.min.js$xhr,script,domain=... is modified to include blog.esuteru.com|pravda.com.ua.
    • The rule for timesofindia.indiatimes.com using ##+js(no-setTimeout-if, adb) is kept.

Overall, this PR significantly reduces the number of active adblocking rules, particularly those targeting html-load.com and associated scripts. This change may result in more ads being displayed on various websites for iOS users of the Brave browser.

@ryanbr ryanbr merged commit 751ec73 into master Aug 27, 2024
6 checks passed
@ryanbr ryanbr deleted the html-lloads branch August 27, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant