Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix audit failures #133

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix audit failures #133

merged 2 commits into from
Sep 15, 2023

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Sep 15, 2023

dependencies = bad

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: tap@16.3.0

@antonok-edm antonok-edm changed the title replace tap with node:test fix audit failures Sep 15, 2023
"dev": true
},
"node_modules/semver": {
"version": "7.3.5",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
[npm-audit] semver vulnerable to Regular Expression Denial of Service

See GHSA-c2qf-rxjj-qqgw
Cc @thypon @bcaller

@@ -19,8 +19,6 @@
},
"homepage": "https://github.com/brave/adblock-resources#readme",
"devDependencies": {
"adblock-rs": "^0.5.6",
"standard": "^17.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonok-edm antonok-edm merged commit ba1fa1c into master Sep 15, 2023
4 checks passed
@antonok-edm antonok-edm deleted the tap-to-builtin-test branch September 15, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants