Update TwitchAdSolutions scripts

[ryanbr]

Re-sync with changes pixeltris/TwitchAdSolutions@144bc99

pixeltris/TwitchAdSolutions#276 (comment)

Adds the Worker check from AdGuard Extra which fixes the black screen / infinite loading wheel

@diracdeltas for a JS review

[github-actions]

_{reported by reviewdog 🐶}
[semgrep] Sauce Token detected

Source: https://semgrep.dev/r/generic.secrets.security.detected-sauce-token.detected-sauce-token


Cc @thypon

[ryanbr]

cc @pixeltris

[pixeltris]

Unfortunately I had to modify the worker check pixeltris/TwitchAdSolutions@0863c6d due to pixeltris/TwitchAdSolutions#277

I can't think of a way to avoid the loading wheel with the current version of TTV LOL PRO

[github-actions]

_{reported by reviewdog 🐶}
[semgrep] Sauce Token detected

Source: https://semgrep.dev/r/generic.secrets.security.detected-sauce-token.detected-sauce-token


Cc @thypon

[github-actions]

[puLL-Merge] - brave/adblock-resources@204

Description

This pull request makes significant changes to the project structure and workflow, primarily focusing on updating the CI process, modernizing JavaScript code, and enhancing ad-blocking scripts for Twitch. The changes aim to improve code quality, maintainability, and the overall functionality of the ad-blocking resources.

Changes

Changes

1. .github/workflows/ci.yml:

   • Added a new comprehensive CI workflow that replaces the previous json_verify.yml and verify_metadata.yml.
   • The new workflow includes steps for verifying JSON files, confirming built resources, and checking formatting.

2. build.js, generateMetadataJsonFromScriptResources.js, index.js:

   • Updated to use ES module syntax instead of CommonJS.
   • Replaced require statements with import statements.
   • Updated file path references to use import.meta.dirname.

3. package.json:

   • Added "type": "module" to enable ES module syntax by default.

4. resources/vaft-ublock-origin.js and resources/video-swap-new-ublock-origin.js:

   • Significant updates to the ad-blocking scripts for Twitch.
   • Refactored code to improve organization and readability.
   • Added new functionality to handle Twitch's ad-serving mechanisms more effectively.
   • Introduced a hookWindowWorker function to intercept and modify Twitch's web worker behavior.

5. verify.js:

   • Updated to use ES module syntax.
   • Added a new function getIDFromBase64PublicKey for generating component IDs.
   • Enhanced tests to verify component IDs against public keys.

Possible Issues

1. The transition to ES modules might cause compatibility issues with environments or tools that expect CommonJS modules.
2. The changes to the Twitch ad-blocking scripts are extensive and may introduce unexpected behavior or break existing functionality if not thoroughly tested.

Security Hotspots

1. The ad-blocking scripts modify browser behavior and interact with Twitch's content. While no immediate vulnerabilities are apparent, these scripts should be carefully reviewed to ensure they don't introduce security risks or violate Twitch's terms of service.

2. The getIDFromBase64PublicKey function in verify.js performs cryptographic operations. While it appears to be used for testing purposes, ensure that it's not used in a security-critical context without proper review.

[ryanbr]

Messed up PR. will do this again