-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Twitch-ads scriptlets #205
Conversation
@diracdeltas is this looks okay |
//This is used to fix the bug where the video would freeze. | ||
try { | ||
//if (navigator.userAgent.toLowerCase().indexOf('firefox') == -1) { | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor issue but we can just delete or comment out the rest of this block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has some quality issues but looks non-malicious. i'm assuming this is just copied from upstream?
going forward @thypon can approve instead of me
Yeah this a direct copy from upstream |
@ryanbr remember to run |
Re-sync with changes pixeltris/TwitchAdSolutions@144bc99 & pixeltris/TwitchAdSolutions@0863c6d
pixeltris/TwitchAdSolutions#276 (comment)