Update Twitch-ads scriptlets #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
thypon
approved these changes
Aug 21, 2024
|
@diracdeltas is this looks okay |
diracdeltas
reviewed
Aug 21, 2024
| //This is used to fix the bug where the video would freeze. | ||
| try { | ||
| //if (navigator.userAgent.toLowerCase().indexOf('firefox') == -1) { | ||
| return; |
There was a problem hiding this comment.
minor issue but we can just delete or comment out the rest of this block
diracdeltas
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
it has some quality issues but looks non-malicious. i'm assuming this is just copied from upstream?
going forward @thypon can approve instead of me
|
Yeah this a direct copy from upstream |
|
@ryanbr remember to run |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-sync with changes pixeltris/TwitchAdSolutions@144bc99 & pixeltris/TwitchAdSolutions@0863c6d
pixeltris/TwitchAdSolutions#276 (comment)